leekeiabstraction commented on code in PR #194:
URL:
https://github.com/apache/flink-connector-aws/pull/194#discussion_r2027386069
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/polling/PollingKinesisShardSplitReader.java:
##########
@@ -48,21 +63,55 @@ public PollingKinesisShardSplitReader(
this.kinesis = kinesisProxy;
this.configuration = configuration;
this.maxRecordsToGet =
configuration.get(KinesisSourceConfigOptions.SHARD_GET_RECORDS_MAX);
+ this.getRecordsIntervalMillis =
configuration.get(SHARD_GET_RECORDS_INTERVAL).toMillis();
+ this.idleSourceGetRecordsIntervalMillis =
+
configuration.get(SHARD_GET_RECORDS_IDLE_SOURCE_INTERVAL).toMillis();
}
@Override
- protected RecordBatch fetchRecords(KinesisShardSplitState splitState) {
+ protected RecordBatch fetchRecords(KinesisShardSplitState splitState)
throws IOException {
+ sleepUntilScheduledGetRecordTime();
Review Comment:
I mistakenly closed the PR by deleting the branch on my fork. Raised a new
PR addressing you comment:
https://github.com/apache/flink-connector-aws/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
