gguptp commented on code in PR #194:
URL:
https://github.com/apache/flink-connector-aws/pull/194#discussion_r2027150246
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/polling/PollingKinesisShardSplitReader.java:
##########
@@ -48,21 +63,55 @@ public PollingKinesisShardSplitReader(
this.kinesis = kinesisProxy;
this.configuration = configuration;
this.maxRecordsToGet =
configuration.get(KinesisSourceConfigOptions.SHARD_GET_RECORDS_MAX);
+ this.getRecordsIntervalMillis =
configuration.get(SHARD_GET_RECORDS_INTERVAL).toMillis();
+ this.idleSourceGetRecordsIntervalMillis =
+
configuration.get(SHARD_GET_RECORDS_IDLE_SOURCE_INTERVAL).toMillis();
}
@Override
- protected RecordBatch fetchRecords(KinesisShardSplitState splitState) {
+ protected RecordBatch fetchRecords(KinesisShardSplitState splitState)
throws IOException {
+ sleepUntilScheduledGetRecordTime();
Review Comment:
Won't this cause the other shards waiting in the assignedSplits queue to get
blocked? Basically, wont this create a head of line blocking effect for the
other shards? Here's how DDB solved this:
https://github.com/apache/flink-connector-aws/pull/190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
