ruanhang1993 commented on code in PR #3767:
URL: https://github.com/apache/flink-cdc/pull/3767#discussion_r2011528567


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:
##########
@@ -109,6 +117,21 @@ public MySqlSnapshotSplitReadTask(
         this.snapshotChangeEventSourceMetrics = 
snapshotChangeEventSourceMetrics;
         this.hooks = hooks;
         this.isBackfillSkipped = isBackfillSkipped;
+
+        // setting column filter
+        String columnIncludeList =
+                
sourceConfig.getDbzConfiguration().getString(COLUMN_INCLUDE_LIST);
+        String columnExcludeList =
+                
sourceConfig.getDbzConfiguration().getString(COLUMN_EXCLUDE_LIST);

Review Comment:
   It seems that only one of `COLUMN_INCLUDE_LIST` and `COLUMN_EXCLUDE_LIST` 
will take effect in snapshot phase.
   And `COLUMN_INCLUDE_LIST` has a higher priority.
   
   Please add an warning for the useless setting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to