lvyanquan commented on code in PR #3767:
URL: https://github.com/apache/flink-cdc/pull/3767#discussion_r2009549490
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:
##########
@@ -305,6 +329,24 @@ private void createDataEventsForTable(
}
}
+ private String getScanColumns(Table table) {
+ List<String> columnNames =
+ table.retrieveColumnNames().stream()
+ .filter(
+ columnName ->
+ columnFilter.matches(
+ table.id().catalog(),
+ table.id().schema(),
+ table.id().table(),
+ columnName))
+ .map(columnName ->
jdbcConnection.quotedColumnIdString(columnName))
+ .collect(Collectors.toList());
+ if (columnNames.isEmpty()) {
+ columnNames.add("*");
+ }
+ return String.join(", ", columnNames);
Review Comment:
Please add a log to print out the return value for troubleshooting.
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/utils/StatementUtils.java:
##########
@@ -131,8 +131,12 @@ public static Object queryNextChunkMax(
}
public static String buildSplitScanQuery(
Review Comment:
Maybe we can add a test for the method as there is not test here before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
