beliefer commented on code in PR #26278:
URL: https://github.com/apache/flink/pull/26278#discussion_r1986283555
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java:
##########
@@ -1340,16 +1340,15 @@ private <IN1, IN2, OUT> TypeInformation<OUT>
createTypeInfoFromFactory(
List<Type> typeHierarchy,
TypeInformation<IN1> in1Type,
TypeInformation<IN2> in2Type) {
-
- final List<Type> factoryHierarchy = new ArrayList<>(typeHierarchy);
- final TypeInfoFactory<? super OUT> factory =
getClosestFactory(factoryHierarchy, t);
+ final List<Type> newTypeHierarchy = new ArrayList<>(typeHierarchy);
Review Comment:
After a second thought. I guess the original author use the name
typeHierarchy due to the list contains the type information according to the
hierarchy.
Such as:
{class java.lang.String, class java.lang.Object}.
So let me temporarily use the name `typeHierarchy`. I am willing to use
`typeHierarchyList` and `newTypeHierarchyList` if more reviewer suggest it.
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java:
##########
@@ -1340,16 +1340,15 @@ private <IN1, IN2, OUT> TypeInformation<OUT>
createTypeInfoFromFactory(
List<Type> typeHierarchy,
TypeInformation<IN1> in1Type,
TypeInformation<IN2> in2Type) {
-
- final List<Type> factoryHierarchy = new ArrayList<>(typeHierarchy);
- final TypeInfoFactory<? super OUT> factory =
getClosestFactory(factoryHierarchy, t);
+ final List<Type> newTypeHierarchy = new ArrayList<>(typeHierarchy);
Review Comment:
After a second thought. I guess the original author use the name
`typeHierarchy` due to the list contains the type information according to the
hierarchy.
Such as:
{class java.lang.String, class java.lang.Object}.
So let me temporarily use the name `typeHierarchy`. I am willing to use
`typeHierarchyList` and `newTypeHierarchyList` if more reviewer suggest it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
