davidradl commented on code in PR #26278:
URL: https://github.com/apache/flink/pull/26278#discussion_r1986262779
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java:
##########
@@ -1340,16 +1340,15 @@ private <IN1, IN2, OUT> TypeInformation<OUT>
createTypeInfoFromFactory(
List<Type> typeHierarchy,
TypeInformation<IN1> in1Type,
TypeInformation<IN2> in2Type) {
-
- final List<Type> factoryHierarchy = new ArrayList<>(typeHierarchy);
- final TypeInfoFactory<? super OUT> factory =
getClosestFactory(factoryHierarchy, t);
+ final List<Type> newTypeHierarchy = new ArrayList<>(typeHierarchy);
Review Comment:
nit: it is not a hierarchy it is a list - if we are changing this why not
change to typeList and rename the related variables to be Lists not hierarchy -
so it is more representative.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
