Zakelly commented on code in PR #26245:
URL: https://github.com/apache/flink/pull/26245#discussion_r1983110713
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStMapState.java:
##########
@@ -139,7 +140,8 @@ public byte[] serializeValue(UV value) throws IOException {
public UV deserializeValue(byte[] valueBytes) throws IOException {
DataInputDeserializer inputView = valueDeserializerView.get();
inputView.setBuffer(valueBytes);
- return userValueSerializer.deserialize(inputView);
+ boolean isNull = inputView.readBoolean();
Review Comment:
That's not true.
when output, writing a single 'false' mean this is not null. 'true' means it
is null.
This is a pair of `readBoolean` / `writeBoolean` for `inputView` /
`outputView`, renaming the method is another topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
