davidradl commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1952955606
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by
Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
Thanks for the detail. I am not an expert at this area. I assume before the
fix SLOT_SHARED_MANAGED would not result in the slot being managed. Now it is
working as expected - I was wondering if we could test that this new code is
causing the slot to be managed. Are you saying the best way to test this is by
testing the owner of the `reservedMemory` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
