davidradl commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1948838156
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by
Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
This looks like a good change. The implication is that before this change
then managed memory per slot was never being used. I was looking for a unit
test of the caller maybe at the ForStSharedResourcesFactory level, to test each
of these shared slot options are being honoured and implemented as expected;
i.e. checking that the slot memory is being managed or not managed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
