sharath1709 commented on code in PR #929:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/929#discussion_r1927813299
##########
flink-autoscaler-standalone/src/test/java/org/apache/flink/autoscaler/standalone/AutoscalerEventHandlerFactoryTest.java:
##########
@@ -68,14 +68,14 @@ void testCreateJdbcEventHandler() throws Exception {
final var conf = new Configuration();
conf.set(EVENT_HANDLER_TYPE, JDBC);
conf.set(JDBC_URL, String.format("%s;create=true", jdbcUrl));
- HikariJDBCUtil.getConnection(conf).close();
+ HikariJDBCUtil.getDataSource(conf).close();
var eventHandler = AutoscalerEventHandlerFactory.create(conf);
assertThat(eventHandler).isInstanceOf(JdbcAutoScalerEventHandler.class);
+ conf.set(JDBC_URL, String.format("%s;shutdown=true", jdbcUrl));
- try {
- conf.set(JDBC_URL, String.format("%s;shutdown=true", jdbcUrl));
- HikariJDBCUtil.getConnection(conf).close();
+ try (var datasource = HikariJDBCUtil.getDataSource(conf)) {
Review Comment:
good catch, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
