sharath1709 commented on code in PR #929:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/929#discussion_r1924523474
##########
flink-autoscaler-plugin-jdbc/src/test/java/org/apache/flink/autoscaler/jdbc/state/JobStateViewTest.java:
##########
@@ -36,25 +35,18 @@
class JobStateViewTest implements DerbyTestBase {
private static final String DEFAULT_JOB_KEY = "jobKey";
- private Connection conn;
+ private DataSource dataSource;
private CountableJdbcStateInteractor jdbcStateInteractor;
private JobStateView jobStateView;
@BeforeEach
void beforeEach() throws Exception {
- this.conn = getConnection();
- this.jdbcStateInteractor = new CountableJdbcStateInteractor(conn);
+ this.dataSource = getDataSource();
+ this.jdbcStateInteractor = new
CountableJdbcStateInteractor(dataSource);
this.jobStateView = new JobStateView(jdbcStateInteractor,
DEFAULT_JOB_KEY);
jdbcStateInteractor.assertCountableJdbcInteractor(1, 0, 0, 0);
}
- @AfterEach
- void afterEach() throws SQLException {
- if (conn != null) {
- conn.close();
Review Comment:
Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
