normanmaurer commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2595168560
So just did read up on this thread and I have a few suggestion.... Just to give some background, I am the Netty Project Lead (if you don't know this already). You definitely should get rid of Netty 3.x. This has been EOL for years which means there are for sure many security related issues and there is also no guarantee that it will work correctly on new Java versions. I know that it might be tempting to just keep using it if things seem to work for now but you will be in big problems if things break for whatever reason or if a critical security bug is found that affects you. So please upgrade asap... Now after all of this is said let's focus on the things you see here and what you can do about it. - I really don't understand why `-Dio.netty.tryReflectionSetAccessible=true` should make a huge difference in terms of memory usage. It is mostly just enabling some optimizations that would reduce GC pressure. I mean it does not hurt to enable it but it would be more for performance then for memory usage. - For best performance you should use the `PooledByteBufAllocator`... That said it is definitely not the right thing to do if you are memory constrained. Like it will never work with the default config if you really only have 7MB. In this case you can switch back to the `UnpooledByteBufAllocator, but will need to pay the extra overhead of frequently allocate / deallocate direct memory. This is expensive compared to heap allocations, so be aware of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
