AlexYinHan commented on code in PR #25924:
URL: https://github.com/apache/flink/pull/25924#discussion_r1917638328
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStResourceContainer.java:
##########
@@ -167,6 +210,43 @@ public ForStResourceContainer(
this.metricGroup = metricGroup;
}
+ private static boolean isDbPathUnderCheckpointPath(
+ @Nullable CheckpointStorageAccess checkpointStorageAccess,
+ @Nullable Path dbRemotePath) {
+ if (dbRemotePath == null) {
+ return false;
+ }
+
+ Preconditions.checkArgument(
+ checkpointStorageAccess instanceof FsCheckpointStorageAccess,
+ "Unexpected checkpointStorageAccess type: "
+ + (checkpointStorageAccess == null
+ ? "null"
+ : checkpointStorageAccess.getClass()));
Review Comment:
I've modified the condition here. For cases involving
```MemoryBackendCheckpointStorageAccess``` and
```FsMergingCheckpointStorageAccess```, this function returns null. Therefore
we will follow the original logic of copying by writing via streams rather than
reusing the files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
