ferenc-csaky commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2580889939
@davidradl My understanding is that Netty4 does not leak memory, simply compared to Netty3 by default it does not work the same way and reserve a bit more memory. But with `-Dio.netty.tryReflectionSetAccessible=true` the default memory footprint will be smaller, and `-Dio.netty.allocator.type=unpooled` can also help with that, but my understanding is that performance wise it is not really advised to use `unpooled` allocation. @He-Pin 7MB is not realistic in any kind of production use-case, for the failing test it is only set that way, because that test validates how much memory is used by Netty, that's why it sets `num-arenas` to 1 and mem to 7MB. My suggestion would be to fix this test instead of revert. Either by giving it more memory, or providing the necessary Netty configs to be able to function with that much memory. For the sake of completeness, on `master` commit https://github.com/apache/flink/commit/338d0246eccd66fbc5e20d433c8cdd090e91574e already increased the memory to 90MB, so backporting that commit to 1.20 and 1.19 could fix that test case mentioned here earlier. Although I'm not sure with those changes that test will be meaningful, because `num-arenas=1` is also removed in that commit. My original idea was to set `-Dio.netty.tryReflectionSetAccessible=true` for this test case, because that way, it fits into 7MB and test execution succeeded multiple times on my local tests for both JDK11 and JDK17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
