yiyutian1 commented on code in PR #25828:
URL: https://github.com/apache/flink/pull/25828#discussion_r1899332994


##########
flink-python/pyflink/table/expressions.py:
##########
@@ -350,14 +350,19 @@ def temporal_overlaps(left_time_point,
 def date_format(timestamp, format) -> Expression:
     """
     Formats a timestamp as a string using a specified format.
-    The format must be compatible with MySQL's date formatting syntax as used 
by the
-    date_parse function.

Review Comment:
   @davidradl , the comment I deleted is not accurate. 
   MySQL's date formatting syntax follows its own date formatting syntax, not 
Java's `SimpleDateFormat` or `DateTimeFormatter`. MySQL is written in C++, not 
Java, and doesn't have much significance as a reference here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to