davidradl commented on code in PR #25790:
URL: https://github.com/apache/flink/pull/25790#discussion_r1881895705
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java:
##########
@@ -273,6 +273,16 @@ public void onNewJobVerticesAdded(List<JobVertex>
newVertices, int pendingOperat
// 4. update json plan
getExecutionGraph().setJsonPlan(JsonPlanGenerator.generatePlan(getJobGraph()));
+
+ // 5. update the DistributionPattern of the upstream results consumed
by the newly created
+ // JobVertex and aggregate subpartition bytes.
Review Comment:
aggregate subpartition bytes. -> aggregate subpartition bytes when possible.
I would find is useful to describe in more detail was aggregate subpartition
bytes means and why we can perform this optimization in some circumstances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
