davidradl commented on code in PR #25592:
URL: https://github.com/apache/flink/pull/25592#discussion_r1878586368
##########
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java:
##########
@@ -60,7 +60,7 @@ public DatadogHttpClient(
String dgApiKey,
String dgProxyHost,
int dgProxyPort,
- DataCenter dataCenter,
+ String dataCenterUrl,
Review Comment:
I think we should add a new constructor and deprecate the old one , for
backwards compatibility.
These methods should all be tagged with @publicEvolving or @Internal as
appropriate.
We should add @deprecate to DataCenter also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
