davidradl commented on code in PR #25592:
URL: https://github.com/apache/flink/pull/25592#discussion_r1878598521
##########
flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java:
##########
@@ -67,20 +67,20 @@ public DatadogHttpReporter(
String proxyHost,
int proxyPort,
int maxMetricsPerRequestValue,
- DataCenter dataCenter,
+ String dataCenterUrl,
String tags,
boolean useLogicalIdentifier) {
this.maxMetricsPerRequestValue = maxMetricsPerRequestValue;
this.useLogicalIdentifier = useLogicalIdentifier;
- this.client = new DatadogHttpClient(apiKey, proxyHost, proxyPort,
dataCenter, true);
+ this.client = new DatadogHttpClient(apiKey, proxyHost, proxyPort,
dataCenterUrl, true);
this.configTags = getTagsFromConfig(tags);
LOGGER.info(
- "Configured DatadogHttpReporter with {tags={}, proxyHost={},
proxyPort={}, dataCenter={}, maxMetricsPerRequest={}",
+ "Configured DatadogHttpReporter with {tags={}, proxyHost={},
proxyPort={}, dataCenterUrl={}, maxMetricsPerRequest={}",
Review Comment:
I was thinking you would keep the original constructor and deprecate it and
add a new constructor for the url.
The log here would then come out reflecting the users config.
I see you have refactored the callers to send through the url. deprecating
might be cleaner. WDYT ?
The methods should all have @publicEvolving @internal tags as appropriate
in all the methods in all the classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
