davidradl commented on PR #25646: URL: https://github.com/apache/flink/pull/25646#issuecomment-2508036414
> > Reviewed by Chi on 28/11/24 business as usual progressing with committer involved. > > I do think that it's very smart to NOT approve PRs where the CI hasn't passed, especially if the failure in CI is related to the change the PR is introducing. @MartijnVisser yes I had previously approved this - thinking it was straight forward. I did not revoke this approval when I realised the CI was failing (I have now). This is a good reminder to revoke my approval when I get more information and also check the the CI succeeds before approving. Thanks for the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
