snuyanzin commented on code in PR #25681:
URL: https://github.com/apache/flink/pull/25681#discussion_r1856602333
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -270,6 +273,16 @@ public static List<String> metadataKeys(TableSourceTable
source) {
: meta.getMetadataKeys();
}
+ public static List<String> sortMetadataKeys(
+ Set<String> allUsedMetadataKeys, DynamicTableSource source) {
+ List<String> allOrderedMetadataKeysFromTable =
+ new ArrayList<>(extractMetadataMap(source).keySet());
+
Review Comment:
nit: can we reuse `extractMetadataMap(source).keySet()` directly rather than
creating a new object
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
