noorall commented on code in PR #25414: URL: https://github.com/apache/flink/pull/25414#discussion_r1856154044
########## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/AdaptiveGraphManager.java: ########## @@ -0,0 +1,697 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.api.graph; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.runtime.jobgraph.IntermediateDataSet; +import org.apache.flink.runtime.jobgraph.IntermediateDataSetID; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.jobgraph.JobVertexID; +import org.apache.flink.runtime.jobgraph.forwardgroup.ForwardGroupComputeUtil; +import org.apache.flink.runtime.jobgraph.forwardgroup.StreamNodeForwardGroup; +import org.apache.flink.runtime.jobmanager.scheduler.SlotSharingGroup; +import org.apache.flink.streaming.api.graph.util.JobVertexBuildContext; +import org.apache.flink.streaming.api.graph.util.OperatorChainInfo; +import org.apache.flink.streaming.runtime.partitioner.ForwardPartitioner; +import org.apache.flink.util.Preconditions; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.LinkedHashMap; +import java.util.LinkedHashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; +import java.util.TreeMap; +import java.util.concurrent.Executor; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.stream.Collectors; + +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.addVertexIndexPrefixInVertexName; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.connect; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.createAndInitializeJobGraph; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.createChain; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.createSourceChainInfo; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.isChainable; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.isSourceChainable; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.markSupportingConcurrentExecutionAttempts; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.preValidate; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.serializeOperatorCoordinatorsAndStreamConfig; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.setAllOperatorNonChainedOutputsConfigs; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.setManagedMemoryFraction; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.setPhysicalEdges; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.setSlotSharingAndCoLocation; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.setVertexDescription; +import static org.apache.flink.streaming.api.graph.StreamingJobGraphGenerator.validateHybridShuffleExecuteInBatchMode; + +/** Default implementation for {@link AdaptiveGraphGenerator}. */ +@Internal +public class AdaptiveGraphManager implements AdaptiveGraphGenerator { + + private final StreamGraph streamGraph; + + private final JobGraph jobGraph; + + private final StreamGraphHasher defaultStreamGraphHasher; + + private final List<StreamGraphHasher> legacyStreamGraphHasher; + + private final Executor serializationExecutor; + + private final AtomicInteger vertexIndexId; + + private final StreamGraphContext streamGraphContext; + + private final Map<Integer, byte[]> hashes; + + private final List<Map<Integer, byte[]>> legacyHashes; + + // Records the id of stream node which job vertex is created. + private final Map<Integer, Integer> frozenNodeToStartNodeMap; + + // When the downstream vertex is not created, we need to cache the output. + private final Map<Integer, Map<StreamEdge, NonChainedOutput>> intermediateOutputsCaches; + + // Records the id of the stream node that produces the IntermediateDataSet. + private final Map<IntermediateDataSetID, Integer> intermediateDataSetIdToProducerMap; + + // Records the ids of the start and end nodes for chained groups in the StreamNodeForwardGroup. + // When stream edge's partitioner is modified to forward, we need get forward groups by source + // and target node id. + private final Map<Integer, StreamNodeForwardGroup> startAndEndNodeIdToForwardGroupMap; + + // Records the chain info that is not ready to create the job vertex, the key is the start node + // in this chain. + private final Map<Integer, OperatorChainInfo> pendingChainEntryPoints; + + // The value is the stream node ids belonging to that job vertex. + private final Map<JobVertexID, Integer> jobVertexToStartNodeMap; + + // The value is the stream node ids belonging to that job vertex. + private final Map<JobVertexID, List<Integer>> jobVertexToChainedStreamNodeIdsMap; + + // We need cache all job vertices to create JobEdge for downstream vertex. + private final Map<Integer, JobVertex> jobVerticesCache; + + // Records the ID of the job vertex that has completed execution. + private final Set<JobVertexID> finishedJobVertices; + + private final AtomicBoolean hasHybridResultPartition; + + private final SlotSharingGroup defaultSlotSharingGroup; + + public AdaptiveGraphManager( + ClassLoader userClassloader, StreamGraph streamGraph, Executor serializationExecutor) { + preValidate(streamGraph, userClassloader); + this.streamGraph = streamGraph; + this.serializationExecutor = Preconditions.checkNotNull(serializationExecutor); + + this.defaultStreamGraphHasher = new StreamGraphHasherV2(); + this.legacyStreamGraphHasher = Collections.singletonList(new StreamGraphUserHashHasher()); + + this.hashes = new HashMap<>(); + this.legacyHashes = Collections.singletonList(new HashMap<>()); + + this.jobVerticesCache = new LinkedHashMap<>(); + this.pendingChainEntryPoints = new TreeMap<>(); + + this.frozenNodeToStartNodeMap = new HashMap<>(); + this.intermediateOutputsCaches = new HashMap<>(); + this.intermediateDataSetIdToProducerMap = new HashMap<>(); + this.startAndEndNodeIdToForwardGroupMap = new HashMap<>(); + + this.vertexIndexId = new AtomicInteger(0); + + this.hasHybridResultPartition = new AtomicBoolean(false); + + this.jobVertexToStartNodeMap = new HashMap<>(); + this.jobVertexToChainedStreamNodeIdsMap = new HashMap<>(); + + this.finishedJobVertices = new HashSet<>(); + + this.streamGraphContext = + new DefaultStreamGraphContext( + streamGraph, + startAndEndNodeIdToForwardGroupMap, + frozenNodeToStartNodeMap, + intermediateOutputsCaches); + + this.jobGraph = createAndInitializeJobGraph(streamGraph, streamGraph.getJobID()); + + this.defaultSlotSharingGroup = new SlotSharingGroup(); + + initialization(); + } + + @Override + public JobGraph getJobGraph() { + return this.jobGraph; + } + + @Override + public StreamGraphContext getStreamGraphContext() { + return streamGraphContext; + } + + @Override + public List<JobVertex> onJobVertexFinished(JobVertexID finishedJobVertexId) { + this.finishedJobVertices.add(finishedJobVertexId); + List<StreamNode> streamNodes = new ArrayList<>(); + for (StreamEdge outEdge : getOutputEdgesByVertexId(finishedJobVertexId)) { + streamNodes.add(streamGraph.getStreamNode(outEdge.getTargetId())); + } + return createJobVerticesAndUpdateGraph(streamNodes); + } + + /** + * Retrieves the StreamNodeForwardGroup which provides a stream node level ForwardGroup. + * + * @param jobVertexId The ID of the JobVertex. + * @return An instance of {@link StreamNodeForwardGroup}. + */ + public StreamNodeForwardGroup getStreamNodeForwardGroupByVertexId(JobVertexID jobVertexId) { Review Comment: > Looks to me this method is only used in tests? If so, maybe we can remove it and further remove `jobVertexToStartNodeMap`? Will be used in later PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
