noorall commented on code in PR #25414:
URL: https://github.com/apache/flink/pull/25414#discussion_r1851480334
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/forwardgroup/ForwardGroupComputeUtilTest.java:
##########
@@ -182,7 +319,56 @@ private static Set<ForwardGroup>
computeForwardGroups(JobVertex... vertices) {
private static void checkGroupSize(
Set<ForwardGroup> groups, int numOfGroups, Integer... sizes) {
assertThat(groups.size()).isEqualTo(numOfGroups);
-
assertThat(groups.stream().map(ForwardGroup::size).collect(Collectors.toList()))
+ assertThat(
+ groups.stream()
+ .map(
+ group -> {
+ if (group instanceof
JobVertexForwardGroup) {
+ return
((JobVertexForwardGroup) group).size();
+ } else {
+ return
((StreamNodeForwardGroup) group).size();
+ }
+ })
+ .collect(Collectors.toList()))
Review Comment:
> Looks to me this change is not needed if invoking this method as proposed
in other comments.
The `size` method in ForwardGroup is only used in tests, so we removed it
when abstracting the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
