Github user thvasilo commented on a diff in the pull request:
https://github.com/apache/flink/pull/2761#discussion_r91119867
--- Diff:
flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/windowing/SessionWindowing.scala
---
@@ -60,11 +64,9 @@ object SessionWindowing {
input.foreach(value => {
ctx.collectWithTimestamp(value, value._2)
ctx.emitWatermark(new Watermark(value._2 - 1))
- if (!fileOutput) {
- println(s"Collected: ${value}")
- }
+ if (!fileOutput) println(s"Collected: ${value}")
--- End diff --
AFAIK we encourage adding braces even for one line if statements, so the
previous version was better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
