Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2761#discussion_r91119469
  
    --- Diff: 
flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/ml/IncrementalLearningSkeleton.scala
 ---
    @@ -159,11 +160,46 @@ object IncrementalLearningSkeleton {
         * Builds up-to-date partial models on new training data.
         */
       private class PartialModelBuilder extends AllWindowFunction[Int, 
Array[Double], TimeWindow] {
    +
    +    protected def buildPartialModel(values: Iterable[Int]): Array[Double] 
= Array[Double](1)
    +
         override def apply(window: TimeWindow,
    -                       input: Iterable[Int],
    +                       values: Iterable[Int],
                            out: Collector[Array[Double]]): Unit = {
    -      out.collect(Array[Double](1.0))
    +      out.collect(buildPartialModel(values))
    +    }
    +  }
    +
    +  /**
    +    * Creates newData using the model produced in batch-processing and the
    +    * up-to-date partial model.
    +    * <p>
    +    * By defaults emits the Integer 0 for every newData and the Integer 1
    --- End diff --
    
    Typo: "defaults" should be "default"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to