gracegrimwood commented on code in PR #25494:
URL: https://github.com/apache/flink/pull/25494#discussion_r1804138258


##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -94,8 +94,8 @@ under the License.
                </dependency>
                <dependency>
                        <groupId>io.netty</groupId>
-                       <artifactId>netty</artifactId>
-                       <version>3.10.6.Final</version>
+                       <artifactId>netty-all</artifactId>

Review Comment:
   @SamBarker is right, after some testing it looks like the minimum we need 
here is `io.netty:netty-all` in `test` scope and the shade plugin relocation of 
`io.netty` to `org.apache.flink.shaded.netty4.io.netty`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to