SamBarker commented on code in PR #25494:
URL: https://github.com/apache/flink/pull/25494#discussion_r1804065549
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -94,8 +94,8 @@ under the License.
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- <version>3.10.6.Final</version>
+ <artifactId>netty-all</artifactId>
Review Comment:
Pekko tests that `io.netty.channel.Channel` is on the classpath so shading
is still required to apply the relocations, even if its not moving the classes
around.
However as shading is only applied during package and so after test
execution something has to supply netty for the tests in `flink-rpc-akka` so
having netty-all in `test` scope rather than `provided` might just work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
