pawel-big-lebowski commented on code in PR #130:
URL:
https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1802998271
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaRecordSerializationSchemaBuilder.java:
##########
@@ -369,5 +377,23 @@ public ProducerRecord<byte[], byte[]> serialize(
value,
headerProvider != null ?
headerProvider.getHeaders(element) : null);
}
+
+ @Override
+ public List<LineageDatasetFacet> getDatasetFacets() {
+ List<LineageDatasetFacet> facets = new ArrayList<>();
+ facets.add(new
KafkaTopicListFacet(Arrays.asList(topicSelector.apply(null))));
Review Comment:
Thanks for pointing this. It works only for the scenario
`KafkaRecordSerializationSchema.builder().setTopic(DEFAULT_TOPIC)`. I've
changed the implementation to more clear on this case.
TopicSelector deserves more abstraction than being just `Function<? super
IN, String>`, but I don't think this should be part of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
