pawel-big-lebowski commented on code in PR #130:
URL: 
https://github.com/apache/flink-connector-kafka/pull/130#discussion_r1802892892


##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/lineage/LineageFacetProvider.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.flink.connector.kafka.lineage;
+
+import org.apache.flink.streaming.api.lineage.LineageDatasetFacet;
+
+import java.util.List;
+
+/**
+ * Contains method which can be used for lineage schema facet extraction. 
Useful for classes like
+ * topic selectors or serialization schemas to extract dataset information 
from.
+ */
+public interface LineageFacetProvider {
+
+    /**
+     * List of lineage dataset facets.
+     *
+     * @return
+     */
+    List<LineageDatasetFacet> getDatasetFacets();

Review Comment:
   flink-core lineage interfaces like `LineageVertex` and `LineageGraph`  also 
have lists, but `Collection` should be enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to