[ 
https://issues.apache.org/jira/browse/FLINK-36476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890045#comment-17890045
 ] 

xuyang commented on FLINK-36476:
--------------------------------

Hi, [~davidradl] .

> I suggest in addition to the code removal and make good, the tests [~Sergey 
>Nuyanzin] mentions, the docs and Python APIs need also be considered.

I agree with you, and I had updated this part in the description yet. 

> My worry is that that the Python API may not have been marked as deprecated, 
> does this stop us removing the deprecated JAVA API if it is relied on?  

IMO, I prefer to just delete it. But this may hurt some Python users. WDYT? 
[~dianfu] [~hxbks2ks] [~lincoln.86xy] 

> Remove all deprecated methods under public APIs in table modules and adapt 
> the related tests to make them pass
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-36476
>                 URL: https://issues.apache.org/jira/browse/FLINK-36476
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / API
>            Reporter: xuyang
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 2.0.0
>
>
> All methods needed to be removed are:
> [https://docs.google.com/document/d/1bVrmcB9UFOd1-sT7xDRTMb5rmO0vK0eDlLRUYYL9gd4/edit?usp=sharing]
>  
> Note:
>  # Please make sure to delete and adapt the code(including test) of module 
> table, python, doc, etc. as well.
>  # Please raise a PR in the corresponding subtask, and try not to link PRs on 
> this umbrella jira.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to