fredia commented on code in PR #25503: URL: https://github.com/apache/flink/pull/25503#discussion_r1802290332
########## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java: ########## Review Comment: Add `AbstractAsyncStateStreamOperatorV2Test#testWatermarkStatus` and `AbstractAsyncStateStreamOperatorTest#testWatermarkStatus` to cover WatermarkStatus. > The processing order between records and non records are not changed. This logic can be verified by current test, a `wait/notify` mechanism is used to verfify that non record can't be processed until record is processed. > All records have been drained before non record is processed. This is not easy to do. `aec.processNonRecord` is a whole unit and we cannot insert a test point in this function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
