fredia commented on code in PR #25503:
URL: https://github.com/apache/flink/pull/25503#discussion_r1798745285
##########
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/operators/AbstractAsyncStateStreamOperator.java:
##########
@@ -345,6 +365,56 @@ public void processWatermarkStatus(WatermarkStatus
watermarkStatus) throws Excep
() -> super.processWatermarkStatus(watermarkStatus));
}
+ @Override
+ protected void processWatermarkStatus(WatermarkStatus watermarkStatus, int
index)
+ throws Exception {
+ if (!isAsyncStateProcessingEnabled()) {
+ super.processWatermarkStatus(watermarkStatus, index);
+ return;
+ }
+ asyncExecutionController.processNonRecord(
+ () -> {
+ boolean wasIdle = combinedWatermark.isIdle();
+ if (combinedWatermark.updateStatus(index - 1,
watermarkStatus.isIdle())) {
Review Comment:
> Should it be index, instead of index - 1?
Yes, it should be `index` in `AbstractAsyncStateStreamOperator` .
> can we directly use () -> super.processWatermarkStatus(...) here?
No, `super.processWatermarkStatus(...)` will call `processWatermark()`
which is overridded by `AbstractAsyncStateStreamOperator`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
