nateab commented on code in PR #25115:
URL: https://github.com/apache/flink/pull/25115#discussion_r1800019486


##########
flink-table/flink-sql-client/src/test/resources/sql/function.q:
##########
@@ -346,3 +346,159 @@ show user functions;
 SHOW JARS;
 Empty set
 !ok
+
+# ==========================================================================
+# test describe function
+# ==========================================================================
+
+ADD JAR '$VAR_UDF_JAR_PATH';
+[INFO] Execute statement succeeded.
+!info
+
+describe function `SUM`;
++-----------------+------------+
+|       info name | info value |
++-----------------+------------+
+| system function |       true |
+|       temporary |      false |
++-----------------+------------+
+2 rows in set
+!ok
+
+describe function extended `SUM`;
++------------------+----------------+
+|        info name |     info value |
++------------------+----------------+
+|  system function |           true |
+|        temporary |          false |
+|             kind |      AGGREGATE |
+|     requirements |             [] |
+|    deterministic |           true |
+| constant folding |           true |
+|        signature | SUM(<NUMERIC>) |
++------------------+----------------+
+7 rows in set
+!ok
+
+describe function temp_upperudf;
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|         info name |                                 $VAR_UDF_JAR_PATH_SPACE 
info value |
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|   system function |                                      
$VAR_UDF_JAR_PATH_SPACE false |
+|         temporary |                                       
$VAR_UDF_JAR_PATH_SPACE true |
+|        class name |                                   
$VAR_UDF_JAR_PATH_SPACE UpperUDF |
+| function language |                                       
$VAR_UDF_JAR_PATH_SPACE JAVA |
+|     resource uris | [ResourceUri{resourceType=JAR, uri='$VAR_UDF_JAR_PATH'}] 
|
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+5 rows in set
+!ok
+
+describe function extended temp_upperudf;
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|         info name |                                 $VAR_UDF_JAR_PATH_SPACE 
info value |
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|   system function |                                      
$VAR_UDF_JAR_PATH_SPACE false |
+|         temporary |                                       
$VAR_UDF_JAR_PATH_SPACE true |
+|        class name |                                   
$VAR_UDF_JAR_PATH_SPACE UpperUDF |
+| function language |                                       
$VAR_UDF_JAR_PATH_SPACE JAVA |
+|     resource uris | [ResourceUri{resourceType=JAR, uri='$VAR_UDF_JAR_PATH'}] 
|
+|              kind |                                     
$VAR_UDF_JAR_PATH_SPACE SCALAR |
+|      requirements |                                         
$VAR_UDF_JAR_PATH_SPACE [] |
+|     deterministic |                                       
$VAR_UDF_JAR_PATH_SPACE true |
+|  constant folding |                                       
$VAR_UDF_JAR_PATH_SPACE true |
+|         signature |                $VAR_UDF_JAR_PATH_SPACE 
c1.db.temp_upperudf(STRING) |
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+10 rows in set
+!ok
+
+desc function temp_upperudf;
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|         info name |                                 $VAR_UDF_JAR_PATH_SPACE 
info value |
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|   system function |                                      
$VAR_UDF_JAR_PATH_SPACE false |
+|         temporary |                                       
$VAR_UDF_JAR_PATH_SPACE true |
+|        class name |                                   
$VAR_UDF_JAR_PATH_SPACE UpperUDF |
+| function language |                                       
$VAR_UDF_JAR_PATH_SPACE JAVA |
+|     resource uris | [ResourceUri{resourceType=JAR, uri='$VAR_UDF_JAR_PATH'}] 
|
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+5 rows in set
+!ok
+
+desc function extended temp_upperudf;
++-------------------+---------------------------------------------$VAR_UDF_JAR_PATH_DASH+
+|         info name |                                 $VAR_UDF_JAR_PATH_SPACE 
info value |

Review Comment:
   This would deviate from what `DESCRIBE CATALOG` currently does, are you okay 
with that? Also see my prior comment on the naming here 
https://github.com/apache/flink/pull/25115#discussion_r1706084728
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to