nateab commented on code in PR #25115:
URL: https://github.com/apache/flink/pull/25115#discussion_r1764239002
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeModel.java:
##########
@@ -41,7 +41,7 @@ public class SqlRichDescribeModel extends SqlCall {
public static final SqlSpecialOperator OPERATOR =
new SqlSpecialOperator("DESCRIBE MODEL", SqlKind.OTHER);
protected final SqlIdentifier modelNameIdentifier;
- private boolean isExtended;
+ private final boolean isExtended;
Review Comment:
not strictly needed, but the IDE preferred it this way, so i wanted to leave
the codebase cleaner than I found it
##########
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlRichDescribeTable.java:
##########
@@ -39,7 +39,7 @@ public class SqlRichDescribeTable extends SqlCall {
public static final SqlSpecialOperator OPERATOR =
new SqlSpecialOperator("DESCRIBE TABLE", SqlKind.DESCRIBE_TABLE);
protected final SqlIdentifier tableNameIdentifier;
- private boolean isExtended = false;
+ private final boolean isExtended;
Review Comment:
not strictly needed, but the IDE preferred it this way, so i wanted to leave
the codebase cleaner than I found it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
