[
https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885217#comment-17885217
]
lajith commented on FLINK-33634:
--------------------------------
[~ryanvanhuuksloot] . Thanks for the comments.
Regarding using different Type other than Ready for Session mode : Reason we
proposed type as Ready for session mode was that it's _ready_ to process Job.
More precise, we can have type as 'JobManagerReady' , but with that in the
Openshift, as mentioned in the FLIP page, it would be populated as with status
_JobManagerReady_ , without of Green tick mark.
Regarding , JobManagerReady status also populated in application mode, In
theory , yes as we already have the Jobmanager status available we can use them
to add to the Condition of the application cluster. Which means we will have
two condition type in application mode . One for Job state and other for
Jobmanger. With that there is slight different in the way status gets displayed
in Openshift UI.
fyi [~davidradl]
> Add Conditions to Flink CRD's Status field
> ------------------------------------------
>
> Key: FLINK-33634
> URL: https://issues.apache.org/jira/browse/FLINK-33634
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
> Affects Versions: kubernetes-operator-1.7.0
> Reporter: Tony Garrard
> Priority: Major
> Labels: pull-request-available
>
> From
> [https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties]
> it is considered best practice to provide Conditions in the Status of CRD's.
> Some tooling even expects there to be a Conditions field in the status of a
> CR. This issue to to propose adding a Conditions field to the CR status
> e.g.
> status:
> conditions:
> - lastTransitionTime: '2023-11-23T12:38:51Z'
> status: 'True'
> type: Ready
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
