[
https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885191#comment-17885191
]
Ryan van Huuksloot commented on FLINK-33634:
--------------------------------------------
I can't easily respond to the mailing list since I don't have an Apache mailing
list account and I wasn't subscribed to the mailing list at the time of
posting. I'll work on being able to respond in the mailing list.
I haven't used application mode with multiple execute blocks but I think this
is an important part of the design so I'd be interested in reviewing once that
investigation is complete.
With respect to Ready, I'd be open to something like JobManagerReady or
ClusterReady or something. The reason I didn't like Ready at the moment is that
it isn't clear what is ready.
Finally, I think if we are doing JobManagerReady for Session Cluster, we might
as well have that Condition for the Application Cluster as well? It doesn't
hurt and is likely very little additional work?
> Add Conditions to Flink CRD's Status field
> ------------------------------------------
>
> Key: FLINK-33634
> URL: https://issues.apache.org/jira/browse/FLINK-33634
> Project: Flink
> Issue Type: Improvement
> Components: Kubernetes Operator
> Affects Versions: kubernetes-operator-1.7.0
> Reporter: Tony Garrard
> Priority: Major
> Labels: pull-request-available
>
> From
> [https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#typical-status-properties]
> it is considered best practice to provide Conditions in the Status of CRD's.
> Some tooling even expects there to be a Conditions field in the status of a
> CR. This issue to to propose adding a Conditions field to the CR status
> e.g.
> status:
> conditions:
> - lastTransitionTime: '2023-11-23T12:38:51Z'
> status: 'True'
> type: Ready
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
