yuxiqian commented on code in PR #3607:
URL: https://github.com/apache/flink-cdc/pull/3607#discussion_r1766431500
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java:
##########
@@ -235,7 +235,7 @@ public DataSource createDataSource(Context context) {
configFactory.chunkKeyColumn(chunkKeyColumnMap);
}
- return new MySqlDataSource(configFactory);
+ return new MySqlDataSource(configFactory,
context.getPipelineConfiguration());
Review Comment:
I was thinking about putting it into `source` block, but parsing it as a
pipeline-level config, just like your current implementation.
Your point is very convincing, surely we shouldn't implement rate limit in
each source connector. Putting it in `pipeline` scope is also reasonable. Maybe
call it something like `source.rate.limit`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
