gaoyan1998 commented on code in PR #3607:
URL: https://github.com/apache/flink-cdc/pull/3607#discussion_r1766461205
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java:
##########
@@ -235,7 +235,7 @@ public DataSource createDataSource(Context context) {
configFactory.chunkKeyColumn(chunkKeyColumnMap);
}
- return new MySqlDataSource(configFactory);
+ return new MySqlDataSource(configFactory,
context.getPipelineConfiguration());
Review Comment:
Good idea，and when I was writing the document, I found that most of the
configuration names in the `pipeline ` are like：
- `local-time-zone`
- `user-defined-functio`
use `-` rather than `.` so，call `source-rate-limit` maybe is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
