[
https://issues.apache.org/jira/browse/FLINK-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719831#comment-15719831
]
ASF GitHub Bot commented on FLINK-5246:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/2930#discussion_r90775426
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -735,15 +735,15 @@ else if (checkpoint != null) {
if
(recentPendingCheckpoints.contains(checkpointId)) {
wasPendingCheckpoint = true;
LOG.warn("Received late message for now
expired checkpoint attempt {}.", checkpointId);
+
+ // try to discard the state so that we
don't have lingering state lying around
+ discardState(message.getState());
}
else {
--- End diff --
We should add a comment here for 1.1 that it's important to not discard the
state here if this was not a known pending checkpoint.
> Don't discard unknown checkpoint messages in the CheckpointCoordinator
> ----------------------------------------------------------------------
>
> Key: FLINK-5246
> URL: https://issues.apache.org/jira/browse/FLINK-5246
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.4
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.1.4
>
>
> The delicate interplay of the {{CheckpointCoordinator}} and the
> {{SavepointCoordinator}} requires that unknown checkpoint messages are not
> discarded but given to the other coordinator. If both coordinator don't
> accept the checkpoint message, then the associated state will be discarded by
> the {{JobManager}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
