[ 
https://issues.apache.org/jira/browse/FLINK-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15718697#comment-15718697
 ] 

ASF GitHub Bot commented on FLINK-5246:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2930

    [FLINK-5246] Don't discard checkpoint messages if they are unknown

    This is the case if the savepoint coordinator has triggered a checkpoint. 
The corresponding
    checkpoint messages are not known to the checkpoint coordinator and thus 
should not be
    discarded. Instead, the JobManager will now discard all messages which have 
not been accepted
    by neither the CheckpointCoordinator nor the SavepointCoordinator.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixCheckpointMessages

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2930
    
----
commit e872b5fbc454e379eab6788bae77c6bf3e2e98af
Author: Till Rohrmann <trohrm...@apache.org>
Date:   2016-12-03T19:15:35Z

    [FLINK-5246] Don't discard checkpoint messages if they are unknown
    
    This is the case if the savepoint coordinator has triggered a checkpoint. 
The corresponding
    checkpoint messages are not known to the checkpoint coordinator and thus 
should not be
    discarded. Instead, the JobManager will now discard all messages which have 
not been accepted
    by neither the CheckpointCoordinator nor the SavepointCoordinator.

----


> Don't discard unknown checkpoint messages in the CheckpointCoordinator
> ----------------------------------------------------------------------
>
>                 Key: FLINK-5246
>                 URL: https://issues.apache.org/jira/browse/FLINK-5246
>             Project: Flink
>          Issue Type: Bug
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.1.4
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.1.4
>
>
> The delicate interplay of the {{CheckpointCoordinator}} and the 
> {{SavepointCoordinator}} requires that unknown checkpoint messages are not 
> discarded but given to the other coordinator. If both coordinator don't 
> accept the checkpoint message, then the associated state will be discarded by 
> the {{JobManager}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to