gaborgsomogyi commented on code in PR #25231:
URL: https://github.com/apache/flink/pull/25231#discussion_r1732814002


##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -129,10 +129,9 @@ public void sync() throws IOException {
         lock();
         try {
             fileStream.flush();
-            openNewPartIfNecessary(userDefinedMinPartSize);
+            uploadCurrentAndOpenNewPart(fileStream.getPos());

Review Comment:
   @MartijnVisser could you plz lend a helping hand here? That said this is 
working in our internal system but happy to do the homework and execute the `S3 
connector test suite` but no idea what we talk about...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to