hlteoh37 commented on code in PR #25231:
URL: https://github.com/apache/flink/pull/25231#discussion_r1726708074
##########
flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/writer/S3RecoverableFsDataOutputStream.java:
##########
@@ -129,10 +129,9 @@ public void sync() throws IOException {
lock();
try {
fileStream.flush();
- openNewPartIfNecessary(userDefinedMinPartSize);
+ uploadCurrentAndOpenNewPart(fileStream.getPos());
Review Comment:
Hm, might be good to do a performance test here and run the manual
integration test. @MartijnVisser Do you know if there are steps for the S3
connector test suite documented anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
