yuxiqian commented on code in PR #41:
URL: 
https://github.com/apache/flink-connector-mongodb/pull/41#discussion_r1719383582


##########
.github/workflows/push_pr.yml:
##########
@@ -28,14 +28,25 @@ jobs:
   compile_and_test:
     strategy:
       matrix:
-        flink: [ 1.18-SNAPSHOT ]
-        jdk: [ '8, 11, 17' ]
+        mongodb: [ mongodb4, mongodb5, mongodb6, mongodb7 ]
+        flink: [ 1.19-SNAPSHOT, 1.20-SNAPSHOT ]
+        jdk: [ '8, 11, 17, 21' ]

Review Comment:
   ~~Will this do the same trick?~~ Nevermind, current code looks neater in CI 
summary.
   
   ```yaml
           mongodb: [ mongodb4, mongodb5, mongodb6, mongodb7 ]
           flink: [ 1.18-SNAPSHOT, 1.19-SNAPSHOT, 1.20-SNAPSHOT ]
           jdk: [ '8, 11, 17', '21' ]
           exclude:
             - flink: 1.18-SNAPSHOT
               jdk: '21'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to