yuxiqian commented on code in PR #41:
URL:
https://github.com/apache/flink-connector-mongodb/pull/41#discussion_r1719355383
##########
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/testutils/MongoTestUtil.java:
##########
@@ -62,7 +62,7 @@ private MongoTestUtil() {}
* @return configured MongoDB container
*/
public static MongoDBContainer createMongoDBContainer(Logger logger) {
- return new MongoDBContainer(DockerImageName.parse(MONGO_4_0))
+ return new MongoDBContainer(mongoDockerImageName())
.withLogConsumer(new Slf4jLogConsumer(logger));
}
Review Comment:
Minor: What about changing `createMongoDBContainer`'s parameter with a more
generic `Consumer` instead of a Logger? Maybe some test cases (in the future)
will require capturing a container's output to something like
`ToStringConsumer()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
