ChengJie1053 commented on PR #3471: URL: https://github.com/apache/flink-cdc/pull/3471#issuecomment-2232291457
> I have two points to be discussed. > > 1. Does 'numRecordsOutByIncremental' refer to the incremental phase here? We don't have a way to determine whether we have reached this phase in the sink now. > 2. If we want to add these metrics, I suggest adding it uniformly though [DataSinkWriterOperator](https://github.com/apache/flink-cdc/blob/94a0415475e7040cc6a61e9bd8aca9c3ccea80ad/flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/sink/DataSinkWriterOperator.java#L63) for all pipeline sinks. Ok, thanks for reviewing the code for me 1.`numRecordsOutByIncremental` the name may be ambiguous, I will modify the name 2.I adding it uniformly though DataSinkWriterOperator for all pipeline sinks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
