yuxiqian commented on code in PR #3471: URL: https://github.com/apache/flink-cdc/pull/3471#discussion_r1677349369
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-kafka/src/main/java/org/apache/flink/cdc/connectors/kafka/sink/KafkaSinkWriteMetrics.java: ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.kafka.sink; + +import org.apache.flink.cdc.common.event.OperationType; +import org.apache.flink.cdc.common.event.TableId; +import org.apache.flink.metrics.Counter; +import org.apache.flink.metrics.MetricGroup; + +import java.util.Map; +import java.util.concurrent.ConcurrentHashMap; + +/** A collection class for handling metrics in {@link PipelineKafkaRecordSerializationSchema}. */ +public class KafkaSinkWriteMetrics { + + private final MetricGroup metricGroup; + + public static final String IO_NUM_RECORDS_OUT_INCREMENTAL_INSERT = + ".numRecordsOutByIncrementalInsert"; + + public static final String IO_NUM_RECORDS_OUT_INCREMENTAL_DELETE = + ".numRecordsOutByIncrementalDelete"; + + public static final String IO_NUM_RECORDS_OUT_INCREMENTAL_UPDATE = + ".numRecordsOutByIncrementalUpdate"; + + private final Map<String, Counter> numRecordsOutMap = new ConcurrentHashMap(); + + public KafkaSinkWriteMetrics(MetricGroup metricGroup) { + this.metricGroup = metricGroup; + } + + public void numRecordsOutInsertIncrease(TableId tableId) { + Counter counter = + numRecordsOutMap.computeIfAbsent( + tableId.identifier() + OperationType.INSERT, Review Comment: As previously pointed out by @lvyanquan, identifier string generating & hashing could be expensive considering it must be done for every DataChangeEvent. What about splitting `INSERT`, `UPDATE`, and `DELETE` counters into three `Map<TableId, Counter>` hash map, so the `TableId` key hash code could be safely cached after we merge #3454? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
