zoltar9264 commented on code in PR #24833:
URL: https://github.com/apache/flink/pull/24833#discussion_r1613094184
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStWriteBatchOperation.java:
##########
@@ -75,7 +74,10 @@ public CompletableFuture<Void> process() {
request.completeStateFuture();
}
} catch (Exception e) {
- throw new CompletionException("Error while adding data
to ForStDB", e);
+ for (ForStDBPutRequest<?, ?> request : batchRequest) {
Review Comment:
Thanks for reminder @masteryhx , firstly this batch operation should indeed
fail in this case. Currently, the AsyncFrameworkExceptionHandler will fail
the job directly, then the StateExecutor will be destroy. I don't see the need
to let the state executor continue executing, so I will fail the executor and
update the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
