masteryhx commented on code in PR #24833:
URL: https://github.com/apache/flink/pull/24833#discussion_r1612797978
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStWriteBatchOperation.java:
##########
@@ -75,7 +74,10 @@ public CompletableFuture<Void> process() {
request.completeStateFuture();
}
} catch (Exception e) {
- throw new CompletionException("Error while adding data
to ForStDB", e);
+ for (ForStDBPutRequest<?, ?> request : batchRequest) {
Review Comment:
This will make the executor continue to run and may everytime
`completeStateFutureExceptionally` all requests.
Could we just `completeStateFutureExceptionally` specific request ? Or fail
the executor ?
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
