fredia commented on code in PR #24653:
URL: https://github.com/apache/flink/pull/24653#discussion_r1582051319
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestExecutorFactory.java:
##########
@@ -56,15 +64,32 @@ ChannelStateWriteRequestExecutor getOrCreateExecutor(
JobVertexID jobVertexID,
int subtaskIndex,
CheckpointStorage checkpointStorage,
+ CheckpointStorageAccess checkpointStorageAccess,
int maxSubtasksPerChannelStateFile,
- boolean startExecutor) {
+ boolean startExecutor,
+ boolean unifyFileMerging) {
synchronized (lock) {
+ int actualMaxSubtasksPerChannelStateFile =
maxSubtasksPerChannelStateFile;
+ ChannelStateWriteRequestDispatcher dispatcher = null;
+ if (!unifyFileMerging) {
+ dispatcher =
+ new ChannelStateWriteRequestDispatcherImpl(
+ checkpointStorage, jobID, new
ChannelStateSerializerImpl());
+ } else {
+ dispatcher =
+ new UnifyMergingChannelStateWriteRequestDispatcher(
Review Comment:
Right, all subtasks will share single thread in this PR, good catch!
I plan to change it to a subtask using an executor, like things before
FLINK-26803. Is this feasible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
