joyCurry30 commented on code in PR #3187:
URL: https://github.com/apache/flink-cdc/pull/3187#discussion_r1560690977


##########
flink-cdc-cli/src/test/resources/definitions/pipeline-definition-full.yaml:
##########
@@ -53,3 +53,8 @@ pipeline:
   name: source-database-sync-pipe
   parallelism: 4
   enable-schema-evolution: false
+  execution.checkpointing.interval: 10000
+  execution.checkpointing.mode: EXACTLY_ONCE
+  # yarn config
+  yarn.staging-directory: /tmp/flink-cdc
+  yarn.application.queue: flink-cdc

Review Comment:
   I don't think this is a good idea. We might need to configure different 
Flink configurations for different tasks, and provide users with an entry point 
to adjust Flink configuration based on their tasks, such as checkpointing or 
task manager memory. If we use the same 'flink-conf.yaml' for every task, it 
will become very inflexible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to