PatrickRen commented on code in PR #3187: URL: https://github.com/apache/flink-cdc/pull/3187#discussion_r1557080409
########## flink-cdc-cli/src/test/resources/definitions/pipeline-definition-full.yaml: ########## @@ -53,3 +53,8 @@ pipeline: name: source-database-sync-pipe parallelism: 4 enable-schema-evolution: false + execution.checkpointing.interval: 10000 + execution.checkpointing.mode: EXACTLY_ONCE + # yarn config + yarn.staging-directory: /tmp/flink-cdc + yarn.application.queue: flink-cdc Review Comment: I'm afraid this will make the YAML even more complex, with so many nested layers. And the name `env-config` is quite vague. Currently we read all Flink configurations from `FLINK_HOME/conf/flink-conf.yaml(config.yaml)`. What about letting users set Flink configurations directly there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
